Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix root option on glob #38

Merged
merged 1 commit into from
Apr 4, 2015
Merged

Conversation

Janpot
Copy link
Contributor

@Janpot Janpot commented Jan 28, 2015

Fixes #37

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.7%) to 96.3% when pulling 985eddf on Janpot:fix-glob-root-option into 6411ea4 on wearefractal:master.

@Janpot
Copy link
Contributor Author

Janpot commented Jan 28, 2015

ok, bad test + coverage, let me fix this

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c276d5d on Janpot:fix-glob-root-option into 6411ea4 on wearefractal:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f7608bf on Janpot:fix-glob-root-option into 6411ea4 on wearefractal:master.

@yocontra
Copy link
Member

rebase?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling de2f38b on Janpot:fix-glob-root-option into 0839bdd on wearefractal:master.

@Janpot
Copy link
Contributor Author

Janpot commented Mar 31, 2015

@contra done

@yocontra
Copy link
Member

Needs docs on what the root option does

@Janpot
Copy link
Contributor Author

Janpot commented Mar 31, 2015

@contra It's already documented here: https://github.com/wearefractal/glob-stream#options

This argument is passed directly to node-glob so check there for more options

Which leads to:

root The place where patterns starting with / will be mounted onto. Defaults to path.resolve(options.cwd, "/") (/ on Unix systems, and C:\ or some such on Windows.)

@Janpot
Copy link
Contributor Author

Janpot commented Apr 4, 2015

@contra Can you give some more input on which extra docs you expect for this PR? In my opinion no extra doc is needed as this is only a bugfix on an existing feature.

yocontra pushed a commit that referenced this pull request Apr 4, 2015
@yocontra yocontra merged commit b8e8f07 into gulpjs:master Apr 4, 2015
phated pushed a commit that referenced this pull request Feb 16, 2017
phated pushed a commit that referenced this pull request Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't play nice with node-glob root option
3 participants