remove the change event object being passed to the callback #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -45,18 +45,14 @@ describe('glob-watcher', function() { | |||
| }); | |||
| }); | |||
|
|
|||
| it('should return a valid file struct via callback', function(done) { | |||
| it('should not pass a file struct via callback', function(done) { | |||
There was a problem hiding this comment.
should not pass any args via callback
|
updated |
|
Weird that coveralls is reporting 100%, istanbul reported less locally. Anyway, this has been updated |
|
Probably needs some doc updates right? |
|
@contra yep, just updated them now. |
yocontra
pushed a commit
that referenced
this pull request
Mar 22, 2015
remove the change event object being passed to the callback
phated
pushed a commit
that referenced
this pull request
Jun 26, 2017
remove the change event object being passed to the callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@contra this will require a major bump so we don't break anyone