Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong namespace for predicates.clj #1

Closed
talios opened this issue May 2, 2009 · 3 comments
Closed

Wrong namespace for predicates.clj #1

talios opened this issue May 2, 2009 · 3 comments

Comments

@talios
Copy link

talios commented May 2, 2009

Looking at the file src/compojure/validation/predicates.clj:

(ns compojure.validation)

(defn blank?
"True if x is nil or an empty string
.....

Should this not be (ns compojure.validation.predicates)? Or an (in-ns...) to append to the namespace?

@weavejester
Copy link
Owner

There's also a blank? in compojure.str-utils, so compojure.validation/blank? should really be removed.

@budu
Copy link
Contributor

budu commented May 5, 2009

That still doesn't answer the issue with the namespace! ;-)

@weavejester
Copy link
Owner

I probably need to revisit compojure.validation and rework bits of it. It might make sense to move it to compojure.validation.predicates for the time being, but it'll need some refactoring sometime in the near future anyway.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants