Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#{:idea} Pass the spec validations step on all defined states before calling init-key. #89

Closed
niwinz opened this issue Dec 31, 2020 · 1 comment

Comments

@niwinz
Copy link

niwinz commented Dec 31, 2020

As far as I know, right now the init-key is called just after spec validation (without validating all others specs). The proposal is have an option to validate first all the config, then initialize all.

This proposal is motivated because of this case use:

  • I proceed starting system, http server pases validtion and starts.
  • The next pre-init-spec fails, and leaves the system in failed state.
  • Now i'm unable to properly stop the jetty, and i can't restart because port is already used by the running jetty that i don't have access to. -> so I need to restart my repl process.

Validating all the specs before starting will help alot prevent this kind of situations.

@niwinz
Copy link
Author

niwinz commented Dec 31, 2020

Closing the issue because is already open #32 (but for some reason i didn't see on my first search).

@niwinz niwinz closed this as completed Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant