Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to urfave/cli #81

Closed
richardcase opened this issue Sep 9, 2021 · 5 comments · May be fixed by #218
Closed

Change to urfave/cli #81

richardcase opened this issue Sep 9, 2021 · 5 comments · May be fixed by #218
Assignees
@souleb
Labels
area/cli Indicates an issue or PR related to the cli plumbing good first issue Good for newcomers help wanted Requires help from contributors to get done kind/refactor Only refactoring changes lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
vNext

Comments

@richardcase
Copy link
Contributor

Describe the solution you'd like:
Change the CLI infra to use urfave/cli instead of cobra/viper.

Why do you want this feature:
This is to make the future deployment option of being combined with containerd easier.

Anything else you would like to add:
@richardcase richardcase added kind/feature New feature or request area/cli Indicates an issue or PR related to the cli plumbing help wanted Requires help from contributors to get done kind/refactor Only refactoring changes and removed kind/feature New feature or request labels Sep 9, 2021
@richardcase richardcase added this to the vNext milestone Sep 9, 2021
@Callisto13 Callisto13 added the good first issue Good for newcomers label Oct 22, 2021
@richardcase richardcase added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Oct 27, 2021
@richardcase
Copy link
Contributor Author

@souleb - we currently also use viper so that there is the option to use a config file/env vars instead of flags:

https://github.com/weaveworks/flintlock/blob/3217c47f5bb2bef558a8c66cf5dbce4ae044cda5/internal/command/root.go#L52

As part of this change could you remove viper as well?

@souleb souleb mentioned this issue Nov 5, 2021
Open
4 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2022

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 3, 2022
@richardcase
Copy link
Contributor Author

This is still needed and there is an open PR

@Callisto13 Callisto13 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 23, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 19, 2023
@github-actions GitHub Actions
Copy link
Contributor

This issue was closed because it has been stalled for 365 days with no activity.

@github-actions github-actions bot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@souleb souleb

Labels
area/cli Indicates an issue or PR related to the cli plumbing good first issue Good for newcomers help wanted Requires help from contributors to get done kind/refactor Only refactoring changes lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
Liquid Metal Roadmap - Public
Status: Closed
Milestone
vNext
Development

Successfully merging a pull request may close this issue.

Refactor the cli functions to use urfave/cli instead of cobra. souleb/flintlock
3 participants
@richardcase @Callisto13 @souleb