chore(test): Add configurable opts to e2e tests #239
Conversation
Callisto13
force-pushed
the
test-params
branch
from
508d129
to
d8a07b7
Compare
|
@yitsushi is the test failure i am seeing vv the thing that a commit in your iface pr is going to fix? |
Hopefully. I did not see errors yet on my branch. And it has much better error message instead of a huge timeout panic. |
Codecov Report
@@ Coverage Diff @@
## main #239 +/- ##
===========================================
- Coverage 55.81% 40.63% -15.19%
===========================================
Files 44 46 +2
Lines 2012 2146 +134
===========================================
- Hits 1123 872 -251
- Misses 781 1214 +433
+ Partials 108 60 -48
Continue to review full report at Codecov.
|
Callisto13
force-pushed
the
test-params
branch
from
d8a07b7
to
f16eff7
Compare
|
ffs since i cannot comment inline apparently: the action update should have been an |
Callisto13
force-pushed
the
test-params
branch
2 times, most recently
from
1a4cb0a
to
c0336fa
Compare
Callisto13
force-pushed
the
test-params
branch
from
c0336fa
to
482f997
Compare
Callisto13
force-pushed
the
test-params
branch
from
482f997
to
e70071d
Compare
I have added the initial frame for custom test flags. So far just the options to: - Skip setting up the devmapper thinpool - Skip deleting VMs - Skip all teardown steps - Set log level for containerd - Set log level for flintlockd Unfortunately custom test flags can only be added on `init()` which is bleh but I don't see another nice was of doing this. These flags can only be used while running `go test ...` directly. This means you cannot pass in flags as part of a `make` or a `docker run -it ...` command, but you can just call `go test etc` from inside the container or in the metal host and configure what you like. My next step is some more work around the python tooling so that these (and more) options can be passed up.
Callisto13
force-pushed
the
test-params
branch
from
e70071d
to
8a41089
Compare
.github/workflows/nightly_e2e.yml
Outdated
| @@ -8,6 +8,7 @@ on: | |||
| jobs: | |||
| e2e: | |||
| runs-on: ubuntu-latest | |||
| if: ${{ secrets.METAL_AUTH_TOKEN != '' && secrets.EQUINIX_ORG_ID != '' }} | |||
There was a problem hiding this comment.
Tried to add a similar check on the docs publish job, but secrets can't be used in condition.
There was a problem hiding this comment.
This logic is a valid workaround:
if: ${{ github.event_name != 'pull_request' && github.repository_owner == 'weaveworks' }}
There was a problem hiding this comment.
boooo stack overflow lied to me 😭
okay ty
Callisto13
force-pushed
the
test-params
branch
from
8a41089
to
29cd4bf
Compare
I have added the initial frame for custom test flags.
So far just the options to:
Unfortunately custom test flags can only be added on
init()which isbleh but I don't see another nice was of doing this.
These flags can only be used while running
go test ...directly.This means you cannot pass in flags as part of a
makeor adocker run -it ...command, but you can just callgo test etcfrom inside thecontainer or in the metal host and configure what you like.
My next step is some more work around the python tooling so that these
(and more) options can be passed up.
part of #146