Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Match Firecracker 1.0.0 API #385

Merged
merged 2 commits into from
Feb 7, 2022

Conversation

yitsushi
Copy link
Contributor

@yitsushi yitsushi commented Feb 7, 2022

What this PR does / why we need it:

I left the AllowMMDSRequests on our side of API, because it think it
makes sense to specify per interface, and under the hood, the
Firecracker provider knows how to handle it.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #384

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

I left the AllowMMDSRequests on our side of API, because it think it
makes sense to specify per interface, and under the hood, the
Firecracker provider knows how to handle it.

Fixes liquidmetal-dev#384
@yitsushi yitsushi added kind/bug Something isn't working area/firecracker Indicates an issue or PR related to Firecracker labels Feb 7, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #385 (e971b1f) into main (f135e32) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
- Coverage   56.67%   56.62%   -0.05%     
==========================================
  Files          52       52              
  Lines        2599     2603       +4     
==========================================
+ Hits         1473     1474       +1     
- Misses       1002     1004       +2     
- Partials      124      125       +1     
Impacted Files Coverage Δ
infrastructure/firecracker/config.go 0.00% <0.00%> (ø)
pkg/process/process.go 37.73% <0.00%> (-1.89%) ⬇️
infrastructure/containerd/event_service.go 59.64% <0.00%> (+3.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f135e32...e971b1f. Read the comment docs.

Copy link
Member

@richardcase richardcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@yitsushi yitsushi merged commit 101e1d5 into liquidmetal-dev:main Feb 7, 2022
@yitsushi yitsushi mentioned this pull request Feb 7, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/firecracker Indicates an issue or PR related to Firecracker kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Match Firecracker API with the 1.0.0 release
4 participants