feat: add support for Firecracker v1+ #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Callisto13
reviewed
Aug 19, 2022
Comment on lines
+180
to
+187
| const ( | ||
| // InstanceStateNotStarted the instance hasn't started running yet. | ||
| InstanceStateNotStarted InstanceState = "Not started" | ||
| // InstanceStateRunning the instance is running. | ||
| InstanceStateRunning InstanceState = "Running" | ||
| // InstanceStatePaused the instance is currently paused. | ||
| InstanceStatePaused InstanceState = "Paused" | ||
| ) |
There was a problem hiding this comment.
lol how many ways of noting status do we have now? i think i count 3
There was a problem hiding this comment.
I know 🤣 I just moved this down to be with their type declaration. We should pickup that bug again thats around the status.
Callisto13
reviewed
Aug 19, 2022
| MicroVM driver. | ||
| | Flintlock | Firecracker | | ||
| | ----------------- | -------------------------------- | | ||
| | v0.3.0 | Official v1.0+ or v1.0.0-macvtap | |
There was a problem hiding this comment.
have a line for 0.2.0 just for completeness?
Callisto13
previously approved these changes
Aug 19, 2022
A small number of changes to support Firecracker v1+. We are sticking with the v1 MMDS initially andf will look to upgrade to the v2 MMDS in the future. To use this version with macvtap we will need to use our fork with the 1.1 changes. NOTE: incorrect serialization caused the issues with MMDS not working. Strangely Firecracker didn't complain about the invalid json config. Time and stress wasted on wht was essentially a type. Signed-off-by: Richard Case <richard.case@outlook.com>
Callisto13
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A few changes to support Firecracker v1+. We are sticking
with the v1 MMDS initially and will look to upgrade to the v2 MMDS in
the future.
To use this version with macvtap we will need to use our fork with the
1.1 changes.
NOTE: incorrect serialization caused the issues with MMDS not working.
Strangely Firecracker didn't complain about the invalid json config.
Time and stress wasted on what was essentially a typo. ffs.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #390
Special notes for your reviewer:
Checklist: