Create GOVERNANCE.md and MAINTAINERS #823
Conversation
GOVERNANCE.md
Outdated
|
|
||
| ## Approving PRs | ||
|
|
||
| Non-specification-related PRs may be merged after receiving at least two organization votes. |
There was a problem hiding this comment.
Does the organisation vote from the person who submitted it, if they're a maintainer, count?
And for PRs from non-maintainers, do we really require 2 votes?
GOVERNANCE.md
Outdated
|
|
||
| Non-specification-related PRs may be merged after receiving at least two organization votes. | ||
|
|
||
| Changes to the CNI Specification also follow the normal PR approval process (eg, 2 organization votes), but any maintainer can request that the approval require a 2/3 majority organization vote. |
There was a problem hiding this comment.
I would just omit "Changes to the CNI Specification also follow the normal PR approval process (eg, 2 organization votes),", and make it clear any maintainer can call for a majority vote on pretty much anything.
There was a problem hiding this comment.
Shouldn't say "CNI" either
GOVERNANCE.md
Outdated
|
|
||
| ## Approving PRs | ||
|
|
||
| Non-specification-related PRs may be merged after receiving at least two organization votes. |
There was a problem hiding this comment.
Should it also say "at least two positive votes"? What if its three against and two for?
GOVERNANCE.md
Outdated
|
|
||
| ## Github Project Administration | ||
|
|
||
| Maintainers will be added to the collaborators list of the cortex repository. |
There was a problem hiding this comment.
Also might want to specify the type of collaborator - "Write, Read, or Admin".
MAINTAINERS
Outdated
| Jonathan Lange, Weaveworks <jml@weave.works> (@jml) | ||
| Julius Volz, independent <> (@jvolz) | ||
| Ken Haines, EA <> (@khaines) | ||
| Tom Wilkie, Grafana <tom> (@tomwilkie) |
There was a problem hiding this comment.
Tom Wilkie, Grafana Labs <tom.wilkie@gmail.com> (@tomwilkie)
There was a problem hiding this comment.
Oops, deleted my prior comment, apologies.
I believe we were planning to add Chris Marchbanks as well, Chris Marchbanks, FreshTracks, <> (@csmarchbanks)
There was a problem hiding this comment.
Ken Haines, Electronic Arts khaines@ea.com (@khaines)
There was a problem hiding this comment.
Chris Marchbanks, FreshTracks chrism@freshtracks.io (@csmarchbanks)
Cody Boggs, FreshTracks cody@freshtracks.io (@cboggs)
GOVERNANCE.md
Outdated
|
|
||
| ## Voting | ||
|
|
||
| The Cortex project employs "organization voting" to ensure no single organization can dominate the project. |
There was a problem hiding this comment.
Agreed to remove "organization voting" rules
|
Is anything else needed on this? Or just an LGTM from everyone in MAINTAINERS? If so: LGTM! |
|
LGTM |
1 similar comment
|
LGTM |
|
LGTM |
1 similar comment
|
LGTM |
|
That appears to make 5/7. Ship it? :-) |
MAINTAINERS
Outdated
| Chris Marchbanks, FreshTracks <chrism@freshtracks.io> (@csmarchbanks) | ||
| Cody Boggs, FreshTracks <cody@freshtracks.io> (@cboggs) | ||
| Jonathan Lange, Weaveworks <jml@weave.works> (@jml) | ||
| Julius Volz, independent <> (@jvolz) |
There was a problem hiding this comment.
Please add my email and the correct GitHub handle:
Julius Volz, independent <julius.volz@gmail.com> (@juliusv)
|
LGTM besides contact fix comment. |
|
Just a ping to @jml for the last LGTM then. |
|
Congrats everyone! |
GOVERENANCE.mdcopied from CNI (as suggested by @bboreham) and is to be edited/reviewed/approved.MAINTAINERSas provided by @bboreham from the previous Cortex community call.