Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to launch all nodes into the same AZ #232

Closed
armandmcqueen opened this issue Sep 29, 2018 · 9 comments
Closed

Add option to launch all nodes into the same AZ #232

armandmcqueen opened this issue Sep 29, 2018 · 9 comments
Labels
help wanted Extra attention is needed kind/feature New feature or request

Comments

@armandmcqueen
Copy link

Why do you want this feature?
We are running ML training workloads on EKS that are very sensitive to network latency. For performance reasons, we need our nodes to exist in a single AZ. Using --zones with a single AZ raises an error.

What feature/behavior/change do you want?
When launching a new cluster, I would like to be able to pass in a single AZ with the --zones option or to have a --single-az flag that forces nodes to launch into the same AZ.

Any workflow that is less unwieldy than manually altering the AutoScaling group's subnet list would be helpful.

@gruebel
Copy link
Contributor

gruebel commented Sep 30, 2018

Hi,
This is not possible due to API restrictions of AWS. You need to specify at least two Subnets in two different AZs.

@armandmcqueen
Copy link
Author

I'm fine with having multiple subnets for EKS. I just need the worker autoscaling group to live in a single AZ.

@errordeveloper
Copy link
Contributor

@armandmcqueen I'm curious to know what happens if you pass e.g. --zones us-west-2a,us-west-2a,us-west-2a?

@gruebel is that an EKS API requirement, or something else?

I think in the future, we should be able to allow this to happen for individual node-groups, perhaps --single-az would makes sense in that context. It'd be nice to allow users to have single-AZ nodegroups at the same time as nodegroups that span multiple AZs.

@errordeveloper errordeveloper added kind/feature New feature or request help wanted Extra attention is needed labels Oct 5, 2018
@gruebel
Copy link
Contributor

gruebel commented Oct 5, 2018

@errordeveloper yeah it is a requirement by the EKS API, if you try it, you will directly get an error message.
I also tried to put in three times the same AZ, then you will get the error and can see in CloudFormation Stack that you need two Subnets in two different AZs.

@errordeveloper
Copy link
Contributor

We will be able to do this very easily soon (namely after #257).

@errordeveloper
Copy link
Contributor

@richardcase as you are working on #281, there's now a NodeGroup.AvailibilityZones field that can be leveraged for this, and I think it would be sufficient to just expose it as a flag as there is plumbing already in place.

https://github.com/weaveworks/eksctl/blob/99b5d58d340660ba7299ee470888b022754a2d8e/pkg/cfn/builder/nodegroup.go#L113-L122

@errordeveloper
Copy link
Contributor

This is definitely done now, and we have ironed out a bug in this week - #432.

@dnascimento
Copy link

Does it assume only one subnet per AZ? Can we deploy on multiple subnets in the same AZ?

@errordeveloper
Copy link
Contributor

errordeveloper commented Sep 19, 2019 via email

torredil pushed a commit to torredil/eksctl that referenced this issue May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants