Cross-platform multi process support #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronjwood
changed the title
5 tasks
michaelbeaumont
approved these changes
May 26, 2020
michaelbeaumont
added a commit
to michaelbeaumont/eksctl
that referenced
this pull request
Jun 26, 2020
This reverts commit 7af3408. This broke eksctl on windows again, unfortunately.
michaelbeaumont
added a commit
to michaelbeaumont/eksctl
that referenced
this pull request
Jun 26, 2020
This reverts commit 7af3408. This broke eksctl on windows again, unfortunately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows for safe concurrent reads/writes to the kubeconfig file. We have some use cases where we run many
eksctlprocesses in parallel. Because of this we need some guarantees that any read-modify-write actions taken on this file are safe against n processes.Checklist
README.md, or theuserdocsdirectory)area/nodegroup), target version (e.g.version/0.12.0) and kind (e.g.kind/improvement)This now works cross-platform instead of only on *nix.