Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KUBECONFIG_USE_SYSTEM_CA env variable to use the system CA instead of the EKS one #2294

Merged
merged 3 commits into from Jun 10, 2020
Merged

Add KUBECONFIG_USE_SYSTEM_CA env variable to use the system CA instead of the EKS one #2294

merged 3 commits into from Jun 10, 2020

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Jun 5, 2020 •
edited

Description

When KUBECONFIG_USE_SYSTEM_CA env variable is set eksctl ignores the cluster CA from EKS

This is the CLI flag env var version
Closes #895

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@michaelbeaumont michaelbeaumont requested review from martina-if and cPu1 and removed request for martina-if June 5, 2020 12:18
@michaelbeaumont michaelbeaumont mentioned this pull request Jun 5, 2020
Closed
@michaelbeaumont michaelbeaumont force-pushed the system_ca branch 2 times, most recently from b0eccc1 to de013de Compare June 8, 2020 16:55
@michaelbeaumont michaelbeaumont changed the title Add --use-system-ca option to ignore cluster CA from EKS Add KUBECONFIG_USE_SYSTEM_CA env variable to ignore cluster CA from EKS Jun 8, 2020
@michaelbeaumont michaelbeaumont marked this pull request as ready for review June 8, 2020 17:07
@martina-if martina-if changed the title Add KUBECONFIG_USE_SYSTEM_CA env variable to ignore cluster CA from EKS Add KUBECONFIG_USE_SYSTEM_CA env variable to use the system CA instead of the EKS one Jun 9, 2020
@martina-if martina-if added kind/feature New feature or request version/0.22.0 labels Jun 9, 2020
@michaelbeaumont
Copy link
Contributor Author

@martina-if I added this var to the FAQs, do you think it makes sense there?

@martina-if martina-if merged commit 8da038f into eksctl-io:master Jun 10, 2020
@michaelbeaumont michaelbeaumont deleted the system_ca branch June 10, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martina-if martina-if martina-if approved these changes

@cPu1 cPu1 Awaiting requested review from cPu1

Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cluster CA validation fails with an HTTPS proxy
2 participants
@michaelbeaumont @martina-if