Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for App Mesh Preview Environment #2310

Merged
merged 1 commit into from Jun 10, 2020
Merged

Add support for App Mesh Preview Environment #2310

merged 1 commit into from Jun 10, 2020

Conversation

stefanprodan
Copy link
Contributor

@stefanprodan stefanprodan commented Jun 9, 2020 •
edited

This PR adds support for App Mesh preview environment. Fix: #2299

Changes:

  • add appMeshPreview addon policy
  • add appmesh-preview-access flag to node groups

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@stefanprodan stefanprodan force-pushed the appmesh-preview branch 2 times, most recently from 9c2c075 to 0150a30 Compare June 9, 2020 08:40
@stefanprodan
Copy link
Contributor Author

stefanprodan commented Jun 9, 2020 •
edited

running make check-all-generated-files-up-to-date locally looks ok, no idea what's going on @martina-if

@martina-if
Copy link
Contributor

@stefanprodan I think it could be because we've been upgrading different tools. Can you run make install-build-deps and make generate-all again? (I can do it for you and commit the changes if you want but it would be good if you have it correctly set up as well)

@stefanprodan
Copy link
Contributor Author

@martina-if thanks! I had the old tooling installed, should be ok now.

martina-if
martina-if reviewed Jun 9, 2020
View reviewed changes
Copy link
Contributor

@martina-if martina-if left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @stefanprodan I added a couple of comments

pkg/cfn/builder/api_test.go Outdated Show resolved Hide resolved
pkg/cfn/builder/iam_helper.go Outdated Show resolved Hide resolved
sayboras
sayboras reviewed Jun 9, 2020
View reviewed changes
Copy link
Contributor

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this file be updated https://github.com/weaveworks/eksctl/blame/master/userdocs/src/usage/iam-policies.md#L18 as well ?

@stefanprodan stefanprodan force-pushed the appmesh-preview branch 2 times, most recently from 3a7eb8b to 91f21c2 Compare June 9, 2020 12:49
@stefanprodan
Copy link
Contributor Author

@sayboras I've updated the yaml, thanks.

@bcelenza
Copy link

bcelenza commented Jun 9, 2020

Thanks for tackling this @stefanprodan !

@stefanprodan
Add support for App Mesh Preview Environment
23fe673 
- add appMeshPreview addon policy
- add appmesh-preview-access flag to node groups

Signed-off-by: stefanprodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan merged commit 2c7b350 into master Jun 10, 2020
@stefanprodan stefanprodan deleted the appmesh-preview branch June 10, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayboras sayboras sayboras left review comments

@martina-if martina-if martina-if approved these changes

Assignees
No one assigned
Labels
area/aws-iam
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support App Mesh Preview Environment
4 participants
@stefanprodan @martina-if @bcelenza @sayboras