Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.22] Config schema doc improvements #2346

Merged

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Jun 19, 2020

Description

https://deploy-preview-2346--eksctl.netlify.app/usage/schema/

#2340

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@michaelbeaumont michaelbeaumont changed the title Config schema doc improvements [release-0.22] Config schema doc improvements Jun 19, 2020
@michaelbeaumont michaelbeaumont added area/docs kind/docs User documentation labels Jun 19, 2020
@michaelbeaumont michaelbeaumont merged commit 86c42e6 into eksctl-io:release-0.22 Jun 19, 2020
michaelbeaumont added a commit to michaelbeaumont/eksctl that referenced this pull request Jun 19, 2020
* Improve docs for NodeGroupSGs

* Add additional AMI options to config docs
michaelbeaumont added a commit that referenced this pull request Jun 23, 2020
* [release-0.22] Improve nodegroup, general config docs (#2342)

* Improve nodegroup config docs

* Some general config schema improvements

* [release-0.22] Config schema doc improvements (#2346)

* Improve docs for NodeGroupSGs

* Add additional AMI options to config docs

* Fix custom AMI link in schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/docs User documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants