Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil pointer dereference in scale command #2416

Merged
merged 3 commits into from Jul 10, 2020
Merged

Fix nil pointer dereference in scale command #2416

merged 3 commits into from Jul 10, 2020

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Jul 10, 2020 •
edited

Description

Discovered while debugging #2415

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@michaelbeaumont michaelbeaumont merged commit 558ffb7 into eksctl-io:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martina-if martina-if martina-if approved these changes

@cPu1 cPu1 cPu1 approved these changes

Assignees
No one assigned
Labels
area/nodegroup kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michaelbeaumont @martina-if @cPu1