Don't replace service account with update-aws-node #2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBBle
reviewed
Jul 21, 2020
| return false, err | ||
| } | ||
| if exists { | ||
| continue |
There was a problem hiding this comment.
It'd be consistent to have a log message indicating that it was skipped, somewhat like the "pretend it was replaced" log message for CustomResourceDefinition directly above.
|
You'll need to update the test as well, since this changes the behaviour when facing a default EKS install, or in fact any EKS install that hasn't had the aws-node manually removed. |
michaelbeaumont
force-pushed
the
aws-node
branch
from
d817998
to
22890e9
Compare
cPu1
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1645
Checklist
README.md, or theuserdocsdirectory)area/nodegroup), target version (e.g.version/0.12.0) and kind (e.g.kind/improvement)