Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disableIMDSv1 config option #2460

Merged
merged 4 commits into from Jul 22, 2020

Conversation

nckturner
Copy link
Contributor

@nckturner nckturner commented Jul 22, 2020

  • Sets the metadata option HttpTokens to "required" on the NodeGroup's LaunchTemplate

Description

An operator might want to create NodeGroups with IMDSv1 disabled, meaning that IMDSv2 tokens are required when querying the instance metadata service from the instance. This pull request gives a config option to disabled IMDSv1 for a given NodeGroup.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

nckturner and others added 3 commits July 22, 2020 11:35
- Sets the metadata option HttpTokens to "required" on the
  NodeGroup's LaunchTemplate
@michaelbeaumont michaelbeaumont merged commit 4aeffce into eksctl-io:master Jul 22, 2020
@michaelbeaumont
Copy link
Contributor

Thanks @nckturner !

@nckturner
Copy link
Contributor Author

Thanks @michaelbeaumont!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/nodegroup kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants