Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for setting Service CIDR range #2546

Merged
merged 1 commit into from Sep 22, 2020
Merged

Add support for setting Service CIDR range #2546

merged 1 commit into from Sep 22, 2020

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Aug 14, 2020 •
edited

Description

Goformation changes: weaveworks/goformation@943d7e9

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@michaelbeaumont michaelbeaumont marked this pull request as draft August 14, 2020 15:33
@michaelbeaumont michaelbeaumont added the kind/feature New feature or request label Aug 14, 2020
@michaelbeaumont michaelbeaumont marked this pull request as ready for review August 17, 2020 07:30
@michaelbeaumont michaelbeaumont marked this pull request as draft August 17, 2020 07:51
cPu1
cPu1 approved these changes Aug 18, 2020
View reviewed changes
Copy link
Collaborator

@cPu1 cPu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We might want to add a validation here to check that the service cluster IP CIDR does not overlap with the primary VPC CIDR.

@michaelbeaumont michaelbeaumont marked this pull request as ready for review September 22, 2020 08:11
@michaelbeaumont michaelbeaumont changed the base branch from release-0.26 to master September 22, 2020 08:13
@michaelbeaumont michaelbeaumont changed the title Add support for setting ClusterIP CIDR range Add support for setting Service CIDR range Sep 22, 2020
@michaelbeaumont michaelbeaumont merged commit 2868207 into eksctl-io:master Sep 22, 2020
@michaelbeaumont michaelbeaumont deleted the clusterip branch September 22, 2020 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 cPu1 approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michaelbeaumont @cPu1