Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go 1.15 upgrade #2652

Merged
merged 5 commits into from Sep 21, 2020
Merged

Go 1.15 upgrade #2652

merged 5 commits into from Sep 21, 2020

Conversation

ajayk
Copy link
Contributor

@ajayk ajayk commented Sep 16, 2020 •
edited

Description

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@ajayk ajayk marked this pull request as draft September 16, 2020 03:40
@ajayk ajayk mentioned this pull request Sep 16, 2020
Closed
5 tasks
@ajayk
Copy link
Contributor Author

ajayk commented Sep 16, 2020

@michaelbeaumont / @martina-if for review

@ajayk ajayk marked this pull request as ready for review September 16, 2020 03:44
michaelbeaumont
michaelbeaumont approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@michaelbeaumont michaelbeaumont merged commit 8ed5140 into eksctl-io:master Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

Assignees
No one assigned
Labels
kind/improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajayk @michaelbeaumont