Deprecate static AMI resolver #2661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martina-if please review. |
martina-if
reviewed
Sep 23, 2020
There was a problem hiding this comment.
Hi @neha-viswanathan , thank you for this PR! I think you also need to delete the code for the static resolver:
pkg/ami/static_resolver.gopkg/ami/static_resolver_ami.gopkg/ami/static_resolver_ami_generate.gopkg/ami/static_resolver_test.go
5 tasks
|
Closing for now until some releases have passed since #2710 |
|
@michaelbeaumont can we reopen this one now? |
1 task
|
Hi! @martina-if martina-if @michaelbeaumont @cPu1 ready for review |
Callisto13
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2650
Description
This MR removes all references to static AMI resolver.
Checklist
README.md, or theuserdocsdirectory)area/nodegroup), target version (e.g.version/0.12.0) and kind (e.g.kind/improvement)