Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix delete iamserviceaccount and withOIDC #2671

Merged
merged 2 commits into from Sep 24, 2020
Merged

Fix delete iamserviceaccount and withOIDC #2671

merged 2 commits into from Sep 24, 2020

Conversation

michaelbeaumont
Copy link
Contributor

Description

Closes #2669

This change makes the SA visible to all commands through IAM.ServiceAccounts, as opposed to inserting it at cluster creation as before

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@michaelbeaumont michaelbeaumont marked this pull request as ready for review September 24, 2020 10:11
@michaelbeaumont michaelbeaumont merged commit ccfc278 into eksctl-io:master Sep 24, 2020
@michaelbeaumont michaelbeaumont deleted the aws-node_acc branch September 24, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 cPu1 approved these changes

Assignees
No one assigned
Labels
area/aws-iam kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression on iamserviceaccount delete command
2 participants
@michaelbeaumont @cPu1