Add format option for utils describe-stacks #2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cPu1
reviewed
Oct 8, 2020
neha-viswanathan
changed the title
cPu1
reviewed
Oct 12, 2020
michaelbeaumont
previously requested changes
Oct 13, 2020
michaelbeaumont
dismissed
their stale review
taken care of, waiting on @cPu1 response
cPu1
reviewed
Oct 14, 2020
cPu1
reviewed
Oct 14, 2020
pkg/ctl/utils/describe_stacks.go
Outdated
| cmdutils.AddTimeoutFlag(fs, &cmd.ProviderConfig.WaitTimeout) | ||
| }) | ||
|
|
||
| cmdutils.AddCommonFlagsForAWS(cmd.FlagSetGroup, &cmd.ProviderConfig, false) | ||
| } | ||
|
|
||
| func doDescribeStacksCmd(cmd *cmdutils.Cmd, all, events, trail bool) error { | ||
| func doDescribeStacksCmd(cmd *cmdutils.Cmd, all, events, trail bool, printer printers.OutputPrinter, output printers.Type) error { | ||
| if output != "" && (all || events || trail) { |
There was a problem hiding this comment.
We should do the validation in RunE, and using flag.Changed (or CobraCommand.Flags.Changed()) is more accurate.
cPu1
reviewed
Oct 14, 2020
|
@cPu1 thanks a lot for your suggestions. I appreciate your guidance. |
cPu1
reviewed
Oct 16, 2020
michaelbeaumont
approved these changes
Oct 16, 2020
michaelbeaumont
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1495
Description
This MR enables the use of a flag
outputfor theeksctl utils describe-stackscommand for JSON or YAML formatted output.How to run
eksctl utils describe-stacks --name=mycluster --output jsonor
eksctl utils describe-stacks --name=mycluster --output yamlChecklist
README.md, or theuserdocsdirectory)area/nodegroup), target version (e.g.version/0.12.0) and kind (e.g.kind/improvement)