Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return non-zero when a given nodegroup doesn't exist #2731

Merged
merged 1 commit into from Oct 13, 2020
Merged

return non-zero when a given nodegroup doesn't exist #2731

merged 1 commit into from Oct 13, 2020

Conversation

ajayk
Copy link
Contributor

@ajayk ajayk commented Oct 13, 2020 •
edited by michaelbeaumont

Description

return non-zero when a given nodegroup doesn't exist , fixes #2728

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@ajayk ajayk marked this pull request as ready for review October 13, 2020 01:30
@michaelbeaumont michaelbeaumont merged commit 36fddb0 into eksctl-io:master Oct 13, 2020
@Callisto13 Callisto13 mentioned this pull request Jan 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eksctl get nodegroup exist with code 0 when nodegroup doesn't exist
2 participants
@ajayk @michaelbeaumont