Handle aws-node 1.7 initContainer properly #2732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@icereed I want to include this in the next RC, can you rebase on |
|
Hi @michaelbeaumont, thanks for the quick reply! I rebased now 😄 |
Since version 1.7 of AWS VPC CNI plugin for Kubernetes the DaemonSet consists additionally of one initContainer. This initContainer needs the same treatment as the main container regarding usage of the regional image. Otherwise the consequence would be a failing pod in China regions or slow image pulls in other regions than us-west-2.
michaelbeaumont
approved these changes
Oct 13, 2020
|
Tested manually, too! 👍 |
|
In terms of planning @michaelbeaumont, would the RC be available today or tomorrow? If no, I would look into options how to include a self-build binary into my tooling in order to fix an issue we have in China regions. |
|
@icereed I'm preparing a release as we speak, should be at the latest this evening (CEST time) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since version 1.7 of AWS VPC CNI plugin for Kubernetes
the DaemonSet consists additionally of one initContainer.
This initContainer needs the same treatment as the main container regarding
usage of the regional image.
Otherwise the consequence would be a failing pod in China regions
or slow image pulls in other regions than us-west-2.
Checklist
README.md, or theuserdocsdirectory)area/nodegroup), target version (e.g.version/0.12.0) and kind (e.g.kind/improvement)