Ensure node drain timeout is respected #2759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pending, err := evictPods(drainer, &node) | ||
| if err != nil { | ||
| logger.Warning("pod eviction error (%q) on node %s – will retry after delay of %s", err, node.Name, retryDelay) | ||
| time.Sleep(retryDelay) |
There was a problem hiding this comment.
Can this function be refactored? It seems crazy complex to me.
nested for loops + breaks seems like a recipe for these kind of bugs IMO
michaelbeaumont
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When draining a node the timeout is not respected. Related issue: #2628. This PR fixes this issue.
Good blog post explaining the issue that was occurring: https://dev.to/julianchu/go-for-select-with-timer-1ah8#timer
Other
I'm questioning the value of the
retryDelay, it makes sense to have a delay between attempting to re-drain the same node, but in its current format theretryDelayresults in a delay between draining different nodes. I haven't addressed this as part of this PR as its a separate issue, just wanted to raise it.Checklist
README.md, or theuserdocsdirectory)area/nodegroup), target version (e.g.version/0.12.0) and kind (e.g.kind/improvement)