Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically install nvidia device plugin for GPU instances #2807

Merged
merged 3 commits into from Nov 10, 2020
Merged

Automatically install nvidia device plugin for GPU instances #2807

merged 3 commits into from Nov 10, 2020

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Nov 9, 2020 •
edited

Description

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@michaelbeaumont michaelbeaumont added the kind/feature New feature or request label Nov 9, 2020
aclevername
aclevername reviewed Nov 10, 2020
View reviewed changes
pkg/eks/tasks.go Outdated
}
var reallyInstallNeuronDevicePlugin bool
for _, ng := range cfg.NodeGroups {
reallyInstallNeuronDevicePlugin = reallyInstallNeuronDevicePlugin || api.HasInstanceType(ng, utils.IsInferentiaInstanceType)
}
var reallyInstallNvidiaDevicePlugin bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we rename this? having reallyInstallNeuronDevicePlugin and installNeuronDevicePluginParam is confusing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

aclevername
aclevername approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@aclevername aclevername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@michaelbeaumont michaelbeaumont merged commit a55826b into eksctl-io:master Nov 10, 2020
@michaelbeaumont michaelbeaumont deleted the nvidia-auto branch November 10, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclevername aclevername aclevername approved these changes

@cPu1 cPu1 Awaiting requested review from cPu1

Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michaelbeaumont @aclevername