Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k8s dependencies #2907

Merged
merged 17 commits into from Dec 14, 2020
Merged

Bump k8s dependencies #2907

merged 17 commits into from Dec 14, 2020

Conversation

aclevername
Copy link
Contributor

Description

Bump all k8s.io imports to latest v0.19.*

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@aclevername
Copy link
Contributor Author

aclevername commented Dec 8, 2020

@michaelbeaumont @cPu1 below is an example failure that occurs with the new k8s dependencies. Similar failures also occur in pkg/addons. From what me and @Callisto13 could tell somewhere down the stack v1 gets swapped out for __internal when parsing the resources gvk (groupVersionKind). This then leads to a failure to pass the object as its not a known version in the schema. It doesn't seem to be related to our code as this conversion happens inside either the client-go or apimachinery package.

$ ginkgo -r pkg/kubernetes/
Running Suite: /Users/jake/weave/eksctl/pkg/kubernetes/kubernetes_suite_test.go
===============================================================================
Random Seed: 1607424845
Will run 17 of 17 specs

•••
------------------------------
• Failure [0.013 seconds]
Kubernetes client wrappers
/Users/jake/weave/eksctl/pkg/kubernetes/client_test.go:16
  can create or replace missing objects
  /Users/jake/weave/eksctl/pkg/kubernetes/client_test.go:17
    can update objects that already exist [It]
    /Users/jake/weave/eksctl/pkg/kubernetes/client_test.go:18

    Unexpected error:
        <*runtime.notRegisteredErr | 0xc0002e64e0>: {
            schemeName: "pkg/runtime/scheme.go:101",
            gvk: {
                Group: "apps",
                Version: "__internal",
                Kind: "DaemonSet",
            },
            target: nil,
            t: nil,
        }
        no kind "DaemonSet" is registered for the internal version of group "apps" in scheme "pkg/runtime/scheme.go:101"
    occurred

    /Users/jake/weave/eksctl/pkg/kubernetes/client_test.go:26

@aclevername aclevername marked this pull request as ready for review December 8, 2020 12:13
@aclevername aclevername requested a review from a team December 8, 2020 13:26
Makefile.docker Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants