Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only use aws-node service account on cluster creation #2917

Merged
merged 1 commit into from Dec 9, 2020
Merged

Only use aws-node service account on cluster creation #2917

merged 1 commit into from Dec 9, 2020

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Dec 9, 2020 •
edited

Description

Fixes #2916

This makes it so that the aws-node ServiceAccount is only auto added to the list of accounts at cluster creation. delete iamserviceaccount now doesn't delete the aws-node account unless explicitly listed and create iamserviceaccount doesn't try to create the aws-node account if it's not listed.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@michaelbeaumont michaelbeaumont changed the title Only mention aws-node service account on cluster creation Only use aws-node service account on cluster creation Dec 9, 2020
@michaelbeaumont michaelbeaumont marked this pull request as ready for review December 9, 2020 11:53
@michaelbeaumont michaelbeaumont requested review from aclevername and a team December 9, 2020 11:53
aclevername
aclevername approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@aclevername aclevername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelbeaumont michaelbeaumont merged commit 2915602 into eksctl-io:master Dec 9, 2020
@michaelbeaumont michaelbeaumont mentioned this pull request Dec 18, 2020
Closed
@cw-sakamoto cw-sakamoto mentioned this pull request Jan 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclevername aclevername aclevername approved these changes

Assignees
No one assigned
Labels
area/aws-iam kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why create/delete iamserviceaccount command modified the service account kube-system/aws-node ?
2 participants
@michaelbeaumont @aclevername