Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add needed parameter --cluster to eksctl utils update-* commands #3103

Merged
merged 1 commit into from Jan 19, 2021
Merged

Add needed parameter --cluster to eksctl utils update-* commands #3103

merged 1 commit into from Jan 19, 2021

Conversation

bt909
Copy link
Contributor

@bt909 bt909 commented Jan 19, 2021

Description

eksctl utils update-* expects the cluster name as parameter, but in the documentation this is not mentioned. I have added this here.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@cPu1 cPu1 added kind/improvement kind/docs User documentation labels Jan 19, 2021
Copy link
Collaborator

@cPu1 cPu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@michaelbeaumont michaelbeaumont merged commit 4f67a79 into eksctl-io:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants