Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix suspend ASG processes for nodegroups #3218

Merged
merged 3 commits into from Feb 8, 2021
Merged

Fix suspend ASG processes for nodegroups #3218

merged 3 commits into from Feb 8, 2021

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Feb 5, 2021 •
edited

Description

Fixes #1355
Don't be scared, it's just new mocks!

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@michaelbeaumont michaelbeaumont added the kind/feature New feature or request label Feb 5, 2021
@michaelbeaumont michaelbeaumont added kind/bug and removed kind/feature New feature or request labels Feb 5, 2021
@michaelbeaumont michaelbeaumont changed the title Really suspend ASG processes for nodegroups Fix suspend ASG processes for nodegroups Feb 5, 2021
@michaelbeaumont michaelbeaumont marked this pull request as ready for review February 5, 2021 16:58
@michaelbeaumont michaelbeaumont requested a review from a team February 5, 2021 17:16
aclevername
aclevername approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@aclevername aclevername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weaveworksbot weaveworksbot merged commit 5ecb98c into eksctl-io:main Feb 8, 2021
@michaelbeaumont michaelbeaumont deleted the asg_sus branch February 8, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 cPu1 approved these changes

@aclevername aclevername aclevername approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suspend ASG processes
4 participants
@michaelbeaumont @cPu1 @aclevername @weaveworksbot