Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always enable timestamps #3251

Merged
merged 3 commits into from Feb 10, 2021
Merged

always enable timestamps #3251

merged 3 commits into from Feb 10, 2021

Conversation

aclevername
Copy link
Contributor

@aclevername aclevername commented Feb 10, 2021 •
edited

Description

This is blocked until this is merged weaveworks/logger#2

New default output:

eksctl delete cluster -f cluster.yaml
2021-02-10 17:37:30 [ℹ]  eksctl version 0.38.0-dev+048f2055.2021-02-10T17:36:51Z
2021-02-10 17:37:30 [ℹ]  using region us-west-2
2021-02-10 17:37:30 [ℹ]  deleting EKS cluster "jk-alb"

Haven't made it configurable, I don't know why you would want it turned off.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@aclevername aclevername added kind/feature New feature or request area/general-cli kind/improvement and removed kind/feature New feature or request labels Feb 10, 2021
@aclevername aclevername linked an issue Feb 10, 2021 that may be closed by this pull request
Timestamps in log lines #3034
Closed
@aclevername aclevername requested a review from a team February 10, 2021 17:53
@aclevername aclevername enabled auto-merge (squash) February 10, 2021 17:55
@aclevername aclevername merged commit 27d972d into eksctl-io:main Feb 10, 2021
@dale-c-anderson dale-c-anderson mentioned this pull request Feb 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Callisto13 Callisto13 Callisto13 approved these changes

Assignees
No one assigned
Labels
area/general-cli kind/improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timestamps in log lines
2 participants
@aclevername @Callisto13