Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OIDC support #3265

Merged
merged 16 commits into from Feb 12, 2021
Merged

OIDC support #3265

merged 16 commits into from Feb 12, 2021

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Feb 12, 2021 •
edited

Description

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@michaelbeaumont michaelbeaumont added the kind/feature New feature or request label Feb 12, 2021
Callisto13
Callisto13 approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@Callisto13 Callisto13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃殌

@michaelbeaumont michaelbeaumont enabled auto-merge (squash) February 12, 2021 19:17
@Callisto13
Copy link
Contributor

Oh are there docs for this? or will you do that next week?

@michaelbeaumont
Copy link
Contributor Author

Yeah there won't be eksctl.io docs yet

@michaelbeaumont michaelbeaumont merged commit 707c8e9 into eksctl-io:release-0.38 Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Callisto13 Callisto13 Callisto13 approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michaelbeaumont @Callisto13