Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sample template for new nodegroup CFN format #3294

Merged
merged 4 commits into from Feb 22, 2021
Merged

Add sample template for new nodegroup CFN format #3294

merged 4 commits into from Feb 22, 2021

Conversation

cPu1
Copy link
Collaborator

@cPu1 cPu1 commented Feb 17, 2021

Description

The nodegroup CFN stack format was changed as part of #3277. This PR updates the example template to use the new format.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@cPu1 cPu1 added the skip-release-notes Causes PR not to show in release notes label Feb 17, 2021
michaelbeaumont
michaelbeaumont approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A careful examination of these templates gives me the confidence to approve this PR

@cPu1 cPu1 enabled auto-merge February 22, 2021 10:32
@cPu1 cPu1 merged commit 418c0b7 into eksctl-io:main Feb 22, 2021
@cPu1 cPu1 deleted the cfn-example-template branch February 25, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

Assignees
No one assigned
Labels
skip-release-notes Causes PR not to show in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cPu1 @michaelbeaumont