Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eks-managed-nodes.md #3653

Merged
merged 5 commits into from May 5, 2021
Merged

Update eks-managed-nodes.md #3653

merged 5 commits into from May 5, 2021

Conversation

lboix
Copy link
Contributor

@lboix lboix commented Apr 30, 2021 •
edited by cPu1

Adding a tip for the usecase where you are describing your whole EKS cluster in just one single file

Description

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@lboix
Update eks-managed-nodes.md
a0dc8e8 
Adding a tip for the usecase where you are describing your whole EKS cluster in just one single file
cPu1
cPu1 requested changes May 2, 2021
View reviewed changes
Copy link
Collaborator

@cPu1 cPu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I left some minor comments but otherwise LGTM.

userdocs/src/usage/eks-managed-nodes.md Outdated Show resolved Hide resolved
userdocs/src/usage/eks-managed-nodes.md Outdated Show resolved Hide resolved
lboix and others added 2 commits May 2, 2021 14:25
@lboix @cPu1
Update userdocs/src/usage/eks-managed-nodes.md
2fd6348 
Co-authored-by: Chetan Patwal <cPu1@users.noreply.github.com>
@lboix @cPu1
Update userdocs/src/usage/eks-managed-nodes.md
77dfe49 
Co-authored-by: Chetan Patwal <cPu1@users.noreply.github.com>
@lboix lboix requested a review from cPu1 May 2, 2021 18:27
@lboix
Copy link
Contributor Author

lboix commented May 2, 2021

Thanks for the PR! I left some minor comments but otherwise LGTM.

I saw them and validated

Thanks for the PR! I left some minor comments but otherwise LGTM.

Thanks for your feedback! I saw them and applied them

@cPu1 cPu1 added the area/docs label May 4, 2021
@lboix lboix requested a review from cPu1 May 4, 2021 12:54
@cPu1 cPu1 added the kind/docs User documentation label May 5, 2021
@cPu1 cPu1 enabled auto-merge (squash) May 5, 2021 15:37
@cPu1 cPu1 merged commit 48c2c54 into eksctl-io:main May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 cPu1 approved these changes

Assignees
No one assigned
Labels
kind/docs User documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lboix @cPu1