Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor common incompatible flags #3895

Merged
merged 2 commits into from
Jun 25, 2021
Merged

Refactor common incompatible flags #3895

merged 2 commits into from
Jun 25, 2021

Conversation

cPu1
Copy link
Collaborator

@cPu1 cPu1 commented Jun 24, 2021 •
edited

Description

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@cPu1 cPu1 enabled auto-merge (squash) June 25, 2021 09:33
@cPu1 cPu1 merged commit 5d8fb43 into eksctl-io:main Jun 25, 2021
@nbusseneau nbusseneau mentioned this pull request Jul 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Callisto13 Callisto13 Callisto13 approved these changes

Assignees
No one assigned
Labels
kind/improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cPu1 @Callisto13