Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure GPU AMI is used when using multiple instances #3924

Merged
merged 2 commits into from Jul 2, 2021
Merged

Ensure GPU AMI is used when using multiple instances #3924

merged 2 commits into from Jul 2, 2021

Conversation

cPu1
Copy link
Collaborator

@cPu1 cPu1 commented Jul 2, 2021 •
edited

Description

Fixes #3848

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@cPu1 cPu1 added the kind/bug label Jul 2, 2021
@cPu1 cPu1 marked this pull request as draft July 2, 2021 09:56
@cPu1 cPu1 marked this pull request as ready for review July 2, 2021 11:04
@cPu1 cPu1 mentioned this pull request Jul 2, 2021
Merged
7 tasks
@cPu1 cPu1 temporarily deployed to Integration tests July 2, 2021 11:13 Inactive
Callisto13
Callisto13 approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@Callisto13 Callisto13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Callisto13
Copy link
Contributor

gonna merge now so we can kick of the tests before the release

@Callisto13 Callisto13 merged commit 0db5c08 into eksctl-io:main Jul 2, 2021
@Callisto13
Copy link
Contributor

Callisto13 commented Jul 2, 2021 •
edited

oh fek were you waiting for integration tests yourself before you merged? sorry! 🤦‍♀️ 😂

@cPu1
Copy link
Collaborator Author

cPu1 commented Jul 2, 2021

oh fek were you waiting for integration tests yourself before you merged? sorry!

No worries 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Callisto13 Callisto13 Callisto13 approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Managed nodegroup: Bottlerocket, unsupported arm64
2 participants
@cPu1 @Callisto13