Deprecate ssh.enableSsm and disallow enabling it
#3989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cPu1
force-pushed
the
ssm-update
branch
4 times, most recently
from
a0aefae
to
06005bb
Compare
|
The link checker check is failing because gopherize.me is returning a 500. |
aclevername
reviewed
Aug 16, 2021
| if ng.SSH != nil { | ||
| if enableSSM := ng.SSH.EnableSSM; enableSSM != nil { | ||
| if !*enableSSM { | ||
| return errors.New("SSM agent is now built into EKS AMIs and cannot be disabled") |
There was a problem hiding this comment.
it can be disabled by using a custom AMI right?
There was a problem hiding this comment.
Good question. The SSM policy will always be added to the node role now, including for custom AMIs, just like we add certain default policies like the CNI plugin policy (if withOIDC is not set), but it can be disabled/overridden by providing attachPolicyARNs.
aclevername
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SSM is now enabled by default and cannot be disabled.
Closes #3882
TODO:
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く