Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vpc-resource-controller/webhook dep to v0.2.6 #4104

Merged
merged 3 commits into from Aug 24, 2021

Conversation

abhipth
Copy link
Contributor

@abhipth abhipth commented Aug 17, 2021

Description

Updating the version for vpc-resource-controller and vpc-admission-webhook from v0.2.5 to v0.2.6.

Controller Latest

 curl --silent https://amazon-eks.s3.us-west-2.amazonaws.com/manifests/us-west-2/vpc-resource-controller/latest/vpc-resource-controller.yaml | grep image:

image: 602401143452.dkr.ecr.us-west-2.amazonaws.com/eks/windows-vpc-resource-controller:v0.2.6

Webhook Latest

curl --silent https://amazon-eks.s3.us-west-2.amazonaws.com/manifests/us-west-2/vpc-admission-webhook/latest/vpc-admission-webhook-deployment.yaml | grep image:

image: 602401143452.dkr.ecr.us-west-2.amazonaws.com/eks/vpc-admission-webhook:v0.2.6

Not able to run make generate-all because of cross OS dependency issue. Could you point me to a documentation for setting up the environment or if possible run it on your setup.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@Callisto13 Callisto13 changed the title bump vpc-resource-controller/webhook dep to v0.2.6 Bump vpc-resource-controller/webhook dep to v0.2.6 Aug 23, 2021
@Callisto13
Copy link
Contributor

Thanks @abhipth .

What OS are you using? All contributing documentation can be found here.

Copy link
Collaborator

@cPu1 cPu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have fixed the build by regenerating the assets. Thanks for the PR!

@cPu1 cPu1 enabled auto-merge (squash) August 24, 2021 12:27
@cPu1 cPu1 merged commit 0551122 into eksctl-io:main Aug 24, 2021
@abhipth abhipth deleted the update-tag branch October 13, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants