Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix creating Windows nodegroups in fully-private clusters #4128

Merged
merged 2 commits into from Aug 25, 2021
Merged

Fix creating Windows nodegroups in fully-private clusters #4128

merged 2 commits into from Aug 25, 2021

Conversation

cPu1
Copy link
Collaborator

@cPu1 cPu1 commented Aug 24, 2021 •
edited

Description

Fixes #2752

TODO:

  • Fix tests

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@cPu1 cPu1 added the kind/bug label Aug 24, 2021
@cPu1 cPu1 force-pushed the windows-private-cluster-fix branch 3 times, most recently from ffd7dd4 to f1f91e7 Compare August 24, 2021 12:26
@cPu1 cPu1 mentioned this pull request Aug 25, 2021
Closed
@cPu1 cPu1 force-pushed the windows-private-cluster-fix branch from f1f91e7 to e8fcd98 Compare August 25, 2021 11:16
@cPu1 cPu1 enabled auto-merge August 25, 2021 11:16
@cPu1 cPu1 merged commit 4a32940 into eksctl-io:main Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikimanoledaki nikimanoledaki nikimanoledaki left review comments

@Callisto13 Callisto13 Callisto13 approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot create Windows Private Cluster Without Internet
3 participants
@cPu1 @Callisto13 @nikimanoledaki