Fail early when instance selector returns too many instances #4139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Callisto13
changed the title
Callisto13
commented
Aug 26, 2021
| @@ -19,6 +19,10 @@ import ( | |||
| "github.com/weaveworks/eksctl/pkg/vpc" | |||
| ) | |||
|
|
|||
| // MaxInstanceTypes is the maximum number of instance types you can specify in | |||
| // a CloudFormation template | |||
| const maxInstanceTypes = 40 | |||
There was a problem hiding this comment.
anyone know if there is a const in aws which already covers this?
cPu1
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4067. (specifically this comment #4067 (comment))
CloudFormation will fail if it gets more than 40 instance types, so with this PR we will fail early to be less annoying.
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く