Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for EC2 detailed monitoring in nodeGroup #4231

Merged
merged 2 commits into from
Sep 21, 2021

Conversation

mmasaki
Copy link
Contributor

@mmasaki mmasaki commented Sep 19, 2021

Description

This change adds support for EC2 detailed monitoring in node group and managed node group.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@Callisto13
Copy link
Contributor

Callisto13 commented Sep 20, 2021

馃憤 Thanks for the PR @mmasaki .

Can we change the field name to detailedMonitoring? Simply monitoring is quite misleading for users, as monitoring: false does not mean that it is disabled, just that it is "basic".

@cPu1
Copy link
Collaborator

cPu1 commented Sep 20, 2021

Thanks for the PR @mmasaki .

Can we change the field name to detailedMonitoring? Simply monitoring is quite misleading for users, as monitoring: false does not mean that it is disabled, just that it is "basic".

I second this. The PR LGTM, however, I think enableDetailedMonitoring would be clearer.

@mmasaki
Copy link
Contributor Author

mmasaki commented Sep 21, 2021

@Callisto13 @cPu1
Thanks for your review.
It's a good idea to change the field name.
I changed it to enableDetailedMonitoring.

Copy link
Collaborator

@cPu1 cPu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR!

@cPu1 cPu1 added the kind/feature New feature or request label Sep 21, 2021
@cPu1 cPu1 merged commit 53dec45 into eksctl-io:main Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants