Scale managed nodegroup with --name flag #4383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikimanoledaki
force-pushed
the
scale-ng-name-bug
branch
from
ef29f03
to
3615f75
Compare
Skarlso
reviewed
Oct 29, 2021
| @@ -166,4 +166,39 @@ var _ = Describe("scale node group config file loader", func() { | |||
| err: fmt.Errorf("at least one of minimum, maximum and desired nodes must be set"), | |||
| }), | |||
| ) | |||
|
|
|||
| Describe("for managed nodegroups", func() { | |||
| Context("when using a config file", func() { | |||
There was a problem hiding this comment.
This could Context could be a When and then just write using a config file? But I don't have a strong opinion on that.
Skarlso
approved these changes
Oct 29, 2021
Himangini
approved these changes
Oct 29, 2021
cPu1
reviewed
Nov 1, 2021
| @@ -44,14 +46,28 @@ func ClusterHasInstanceType(cfg *ClusterConfig, hasType func(string) bool) bool | |||
| return false | |||
| } | |||
|
|
|||
| // HasNodegroup returns true if this clusterConfig contains a managed or un-managed nodegroup with the given name | |||
| func (c *ClusterConfig) FindNodegroup(name string) *NodeGroup { | |||
| // FindNodegroup returns true if this clusterConfig contains a managed or un-managed nodegroup with the given name | |||
There was a problem hiding this comment.
This comment needs to be updated to match the signature.
There was a problem hiding this comment.
thanks, updated it!
nikimanoledaki
force-pushed
the
scale-ng-name-bug
branch
from
3615f75
to
6659f2b
Compare
cPu1
approved these changes
Nov 2, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug in #2655
The issue was that when a user was doing
eksctl scale nodegroup --config-file x --name y, eksctl was not looking in the config file for managed nodegroups. This only worked for unmanaged nodegroups.Iterating over
managedNodeGroupsas well and then returning the nodegroup base (which is common to both types of ng) fixes this issue.A separate PR will address scaling all nodegroups in the config file if the name flag is not provided.
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く