Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get clusters --all-regions #4563

Merged
merged 2 commits into from
Jan 5, 2022
Merged

Fix get clusters --all-regions #4563

merged 2 commits into from
Jan 5, 2022

Conversation

cPu1
Copy link
Collaborator

@cPu1 cPu1 commented Jan 4, 2022

Description

When an AWS account has access to a region not supported by EKS, get clusters --all-regions attempts to query that region for EKS clusters, which fails. This changelist ensures only regions supported by EKS are queried for clusters.

Fixes #4560

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

pkg/eks/eks.go Show resolved Hide resolved
@cPu1 cPu1 marked this pull request as draft January 4, 2022 09:30
@cPu1 cPu1 force-pushed the fix-get-all-regions branch 2 times, most recently from 571767e to fedab3c Compare January 4, 2022 11:51
@cPu1 cPu1 marked this pull request as ready for review January 4, 2022 11:52
When an AWS account has access to a region not supported by EKS, `get clusters --all-regions` attempts to query that region for EKS clusters, which fails.
This changelist ensures only regions supported by EKS are queried for clusters.
Copy link
Contributor

@Skarlso Skarlso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! :)

@cPu1 cPu1 enabled auto-merge January 5, 2022 13:48
@cPu1 cPu1 merged commit 3c0e0bd into main Jan 5, 2022
@cPu1 cPu1 deleted the fix-get-all-regions branch January 5, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eksctl get clusters, --all-regions flag throws error
3 participants