Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build image URL in Dockerfile #4893

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Fix build image URL in Dockerfile #4893

merged 2 commits into from
Mar 8, 2022

Conversation

cPu1
Copy link
Collaborator

@cPu1 cPu1 commented Mar 4, 2022 •
edited

Description

Fixes #4813

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@aclevername aclevername requested a review from a team March 7, 2022 17:17
Himangini
Himangini approved these changes Mar 8, 2022
View reviewed changes
Copy link
Collaborator

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤馃徎

@cPu1 cPu1 enabled auto-merge (squash) March 8, 2022 11:07
@cPu1 cPu1 merged commit 5c83d40 into eksctl-io:main Mar 8, 2022
@hspencer77 hspencer77 mentioned this pull request Jul 8, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Himangini Himangini Himangini approved these changes

@aclevername aclevername aclevername approved these changes

Assignees

@cPu1 cPu1

Labels
area/ci kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update-build-image-tag erroneously adds a leading / to the Dockerfile
3 participants
@cPu1 @Himangini @aclevername