Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin karpenter support to 0.6.* #4903

Merged
merged 5 commits into from
Mar 8, 2022
Merged

Conversation

aclevername
Copy link
Contributor

@aclevername aclevername commented Mar 4, 2022

Description

Closes #4827

sad path:

cat cluster.yaml
apiVersion: eksctl.io/v1alpha5
kind: ClusterConfig

metadata:
  name: cluster-with-karpenter
  region: us-west-2
  version: '1.21'
  tags:
    karpenter.sh/discovery: cluster-with-karpenter

iam:
  withOIDC: true

karpenter:
  version: '0.7.2'
  createServiceAccount: true # default is false

./eksctl create cluster -f cluster.yaml
Error: failed to validate karpenter config: failed to validate karpenter config: maximum supported version is 0.6  

happy path:

cat cluster.yaml
apiVersion: eksctl.io/v1alpha5
kind: ClusterConfig

metadata:
  name: cluster-with-karpenter
  region: us-west-2
  version: '1.21'
  tags:
    karpenter.sh/discovery: cluster-with-karpenter

iam:
  withOIDC: true

karpenter:
  version: '0.6.2'

./eksctl create cluster -f cluster.yaml
2022-03-04 16:52:36 [ℹ]  eksctl version 0.88.0-dev+d66dc7c3.2022-03-04T16:51:04Z
2022-03-04 16:52:36 [ℹ]  using region us-west-2
2022-03-04 16:52:37 [ℹ]  setting availability zones to [us-west-2b us-west-2d us-west-2c]
2022-03-04 16:52:37 [ℹ]  subnets for us-west-2b - public:192.168.0.0/19 private:192.168.96.0/19
2022-03-04 16:52:37 [ℹ]  subnets for us-west-2d - public:192.168.32.0/19 private:192.168.128.0/19
2022-03-04 16:52:37 [ℹ]  subnets for us-west-2c - public:192.168.64.0/19 private:192.168.160.0/19
2022-03-04 16:52:37 [ℹ]  nodegroup "managed-ng-1" will use "" [AmazonLinux2/1.21]
2022-03-04 16:52:37 [ℹ]  using Kubernetes version 1.21
...

cfg.Karpenter = &api.Karpenter{
Version: "0.5.1",
Version: "isitmeeeyourlookingfoorrrr",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Himangini
Copy link
Collaborator

Nicely done 👍🏻

  • Can we add some docs around this as mentioned in the main ticket?
  • Can we capitalise the first letter of the title so it looks nice in release notes?

Copy link
Contributor

@nikimanoledaki nikimanoledaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
edit: just saw what Gini said - I agree!

@aclevername
Copy link
Contributor Author

  • Can we capitalise the first letter of the title so it looks nice in release notes?

Feel free to edit PR titles, don't need to ask 😄

@aclevername aclevername changed the title pin karpenter support to 0.6.* Pin karpenter support to 0.6.* Mar 7, 2022
@aclevername aclevername enabled auto-merge (squash) March 8, 2022 09:32
@aclevername aclevername merged commit 72e2f58 into eksctl-io:main Mar 8, 2022
@hspencer77 hspencer77 mentioned this pull request Jul 8, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin karpenter support to a specific minor
4 participants