Fix setting ownership status when listing clusters #4911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good job getting a fix quickly! :) Could you add unit tests please? |
aclevername
suggested changes
Mar 7, 2022
cPu1
force-pushed
the
fix-owned-cluster-status
branch
2 times, most recently
from
01209e6
to
d340dd5
Compare
cPu1
commented
Mar 8, 2022
|
|
||
| // AssertContainsCluster asserts that the output of the specified command contains the specified cluster | ||
| func AssertContainsCluster(cmd runner.Cmd, out GetClusterOutput) { | ||
| Expect(cmd).To(runner.RunSuccessfullyWithOutputStringLines( |
There was a problem hiding this comment.
Intentionally not using a dot import because runner.Cmd is also being used here.
aclevername
approved these changes
Mar 9, 2022
Skarlso
reviewed
Mar 10, 2022
Skarlso
approved these changes
Mar 10, 2022
Instead of using the `clusterName` argument, the method was obtaining the cluster name via the `spec` field.
cPu1
force-pushed
the
fix-owned-cluster-status
branch
from
d340dd5
to
e5e25d0
Compare
cPu1
added a commit
to cPu1/eksctl
that referenced
this pull request
Mar 11, 2022
PR eksctl-io#4911 fixed a bug where the `clusterName` parameter was not being used when obtaining a cluster's ownership for `get clusters`. The logic for checking owned clusters, however, relied on this behaviour, breaking the check for cluster ownership.
7 tasks
Skarlso
added a commit
that referenced
this pull request
Mar 14, 2022
* Fix checking cluster stack for owned clusters PR #4911 fixed a bug where the `clusterName` parameter was not being used when obtaining a cluster's ownership for `get clusters`. The logic for checking owned clusters, however, relied on this behaviour, breaking the check for cluster ownership. * Added unit tests * Apply suggestions from code review Co-authored-by: Jake Klein <jakelarsj@gmail.com> * Added error case. * Fix error import Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Co-authored-by: Jake Klein <jakelarsj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of using the
clusterNameargument, the method was obtaining the cluster name via thespecfield.Fixes #4888
This changelist correctly sets the
EKSCTL CREATEDcolumn toTruefor clusters created via eksctl:Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く