Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken links to 'IAM Service Accounts' in docs #4912

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Fix broken links to 'IAM Service Accounts' in docs #4912

merged 1 commit into from
Mar 8, 2022

Conversation

thinkmassive
Copy link
Contributor

Description

Minor docs edit to fix broken links. Old links went to /iamserviceaccounts but it looks like that page has moved to be under /usage/iamserviceaccounts

Checklist

  • Added tests that cover your change (if possible) n/a
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested n/a
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@thinkmassive thinkmassive changed the title docs: fix broken links iamserviceaccounts [minor] docs: fix broken links to 'IAM Service Accounts' [minor] Mar 7, 2022
cPu1
cPu1 approved these changes Mar 8, 2022
View reviewed changes
Copy link
Collaborator

@cPu1 cPu1 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted!

@nikimanoledaki nikimanoledaki added the kind/docs User documentation label Mar 8, 2022
nikimanoledaki
nikimanoledaki approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@nikimanoledaki nikimanoledaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for the PR @thinkmassive 馃帀

@nikimanoledaki nikimanoledaki changed the title docs: fix broken links to 'IAM Service Accounts' [minor] Fix broken links to 'IAM Service Accounts' in docs Mar 8, 2022
@nikimanoledaki nikimanoledaki enabled auto-merge (squash) March 8, 2022 07:51
@nikimanoledaki nikimanoledaki merged commit 77f31d6 into eksctl-io:main Mar 8, 2022
@thinkmassive thinkmassive deleted the docs-link-fixes branch March 8, 2022 11:42
@cPu1 cPu1 mentioned this pull request Mar 9, 2022
Merged
7 tasks
@hspencer77 hspencer77 mentioned this pull request Jul 8, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 cPu1 approved these changes

@nikimanoledaki nikimanoledaki nikimanoledaki approved these changes

Assignees
No one assigned
Labels
kind/docs User documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thinkmassive @cPu1 @nikimanoledaki