Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate usage of IAM to aws-sdk-go-v2 #5035

Merged
merged 2 commits into from Apr 12, 2022
Merged

Conversation

cPu1
Copy link
Collaborator

@cPu1 cPu1 commented Mar 31, 2022

Description

Migrates usage of IAM to aws-sdk-go-v2. One notable change is that a new interface ResourceSetReader, containing a subset of the ResourceSet methods, has been added.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@cPu1 cPu1 added kind/improvement area/tech-debt Leftover improvements in code, testing and building labels Mar 31, 2022
@cPu1 cPu1 force-pushed the migrate-iam-sdk-v2 branch 4 times, most recently from 70d9967 to 50bbedd Compare April 7, 2022 09:56
@cPu1 cPu1 marked this pull request as ready for review April 7, 2022 10:17
@Himangini Himangini requested a review from a team April 7, 2022 13:23
Copy link
Contributor

@Skarlso Skarlso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A single comment and one question... You mix Background and TODO for context here and there. What makes you choose one over the other? :)

@cPu1
Copy link
Collaborator Author

cPu1 commented Apr 7, 2022

A single comment and one question... You mix Background and TODO for context here and there. What makes you choose one over the other? :)

I have used context.Background() in tests where we don't need to worry about supplying an appropriate Context. context.TODO() is used in the main code to ensure we revisit this later and determine if a deadline-based or cancellable Context can be used.

@nikimanoledaki
Copy link
Contributor

context.TODO() is used in the main code to ensure we revisit this later and determine if a deadline-based or cancellable Context can be used.

Is there a new issue to track this?

@cPu1
Copy link
Collaborator Author

cPu1 commented Apr 8, 2022

context.TODO() is used in the main code to ensure we revisit this later and determine if a deadline-based or cancellable Context can be used.

Is there a new issue to track this?

I have created one: #5093.

Copy link
Collaborator

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cPu1 cPu1 merged commit b4424f5 into eksctl-io:main Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tech-debt Leftover improvements in code, testing and building kind/improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants