Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add override integration test #5094

Merged
merged 2 commits into from Apr 11, 2022

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Apr 8, 2022

Description

Closes #4972

Added a simple integration test to test functionality of overriding using two nodegroups and a configuration file. Nodegroup 1 is unmanaged and nodegroup 2 is managed, testing both at the same time.

Local run:

Ran 1 of 1 Specs in 1704.933 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestOverrideBootstrap (1704.93s)
PASS

Ginkgo ran 1 suite in 28m47.554883904s
Test Suite Passed

This is a basic test suite which can be extended upon later with various scenarios.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

Copy link
Collaborator

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤馃徎

@Skarlso Skarlso merged commit 3621961 into eksctl-io:main Apr 11, 2022
SlevinWasAlreadyTaken pushed a commit to SlevinWasAlreadyTaken/eksctl that referenced this pull request Apr 13, 2022
@hspencer77 hspencer77 mentioned this pull request Jul 8, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Extend the integration tests with testing overrideBootstrapCommand and custom AMI features
3 participants