Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only select zones which are of type availability-zone #5112

Merged
merged 3 commits into from Apr 13, 2022
Merged

Only select zones which are of type availability-zone #5112

merged 3 commits into from Apr 13, 2022

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Apr 12, 2022

Description

Closes #5110

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@Skarlso Skarlso force-pushed the fix-selecting-local-zones-as-azs branch from d6fbb74 to 3ea25e9 Compare April 12, 2022 11:03
@Skarlso Skarlso force-pushed the fix-selecting-local-zones-as-azs branch from 3ea25e9 to 97af29c Compare April 12, 2022 11:14
@Skarlso Skarlso force-pushed the fix-selecting-local-zones-as-azs branch from 97af29c to 7a8611f Compare April 12, 2022 11:15
cPu1
cPu1 reviewed Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@cPu1 cPu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you'll need to rebase and migrate the SDK v1 EC2 types to v2.

@Skarlso
Copy link
Contributor Author

Skarlso commented Apr 12, 2022

Yeah. :D Just saw the conflicts.. :D

@Skarlso Skarlso requested a review from cPu1 April 12, 2022 12:35
@Skarlso Skarlso force-pushed the fix-selecting-local-zones-as-azs branch from e59a238 to cb3c6a7 Compare April 12, 2022 13:39
@Skarlso Skarlso enabled auto-merge (squash) April 13, 2022 09:52
@Skarlso Skarlso merged commit 9b7698c into eksctl-io:main Apr 13, 2022
SlevinWasAlreadyTaken pushed a commit to SlevinWasAlreadyTaken/eksctl that referenced this pull request Apr 13, 2022
@Skarlso @SlevinWasAlreadyTaken
Only select zones which are of type availability-zone (eksctl-io#5112)
07e17e1
LisaBrown3
LisaBrown3 reviewed Apr 21, 2022
View reviewed changes
Copy link

@LisaBrown3 LisaBrown3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5002
Duplicate of #
Duplicate of #

``

@cPu1
Copy link
Collaborator

cPu1 commented Apr 21, 2022

#5002 Duplicate of # Duplicate of #

``

@LisaBrown3 Did you mean to comment that on this issue?

@hspencer77 hspencer77 mentioned this pull request Jul 8, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LisaBrown3 LisaBrown3 LisaBrown3 left review comments

@cPu1 cPu1 cPu1 approved these changes

@Himangini Himangini Himangini approved these changes

@nikimanoledaki nikimanoledaki Awaiting requested review from nikimanoledaki

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] eksctl selects local zones as availability zones if none are defined during cluster creation
4 participants
@Skarlso @cPu1 @Himangini @LisaBrown3